Added Ellipsoid surface area #8986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much for the pull request @ErixenCruz! I noticed this is your first pull request and I wanted to say welcome to the Cesium community! The Pull Request Guidelines is a handy reference for making sure your PR gets accepted quickly, so make sure to skim that.
Reviewers, don't forget to make sure that:
|
lilleyse
reviewed
Jun 23, 2020
CHANGES.md
Outdated
| - Added support for PolylineVolume in CZML [#8841](https://github.com/CesiumGS/cesium/pull/8841) | ||
|
|
||
| ##### Fixes :wrench: | ||
|
|
||
| - Fixed `Ellipsoid.geodeticSurfaceNormal` dividing by zero when given origin as input. |
There was a problem hiding this comment.
Suggested change
| - Fixed `Ellipsoid.geodeticSurfaceNormal` dividing by zero when given origin as input. | |
| - Fixed a divide-by-zero bug in `Ellipsoid.geodeticSurfaceNormal` when given the origin as input. `undefined` is returned instead. [#8986](https://github.com/CesiumGS/cesium/pull/8986) |
CHANGES.md
Outdated
| @@ -8,10 +8,12 @@ | |||
|
|
|||
| ##### Additions :tada: | |||
|
|
|||
| - Added `Ellipsoid.surfaceArea` for computing the surface area under given rectangle. | |||
There was a problem hiding this comment.
Suggested change
| - Added `Ellipsoid.surfaceArea` for computing the surface area under given rectangle. | |
| - Added `Ellipsoid.surfaceArea` for computing the approximate surface area of a rectangle on the surface of an ellipsoid. |
| @@ -3,6 +3,7 @@ import { Cartographic } from "../../Source/Cesium.js"; | |||
| import { Ellipsoid } from "../../Source/Cesium.js"; | |||
| import { Math as CesiumMath } from "../../Source/Cesium.js"; | |||
| import createPackableSpecs from "../createPackableSpecs.js"; | |||
| import { Rectangle } from "../../Source/Cesium.js"; | |||
There was a problem hiding this comment.
Just to keep things tidy, move this import above one line so it's next to the other Cesium.js imports.
Source/Core/Ellipsoid.js
Outdated
| */ | ||
|
|
||
| /** | ||
| * Computes an approximation of the surface area of a given section of the surface of an ellipsoid using |
There was a problem hiding this comment.
Suggested change
| * Computes an approximation of the surface area of a given section of the surface of an ellipsoid using | |
| * Computes an approximation of the surface area of a rectangle on the surface of an ellipsoid using |
Source/Core/Ellipsoid.js
Outdated
| * Gauss-Legendre 10th order quadrature. | ||
| * | ||
| * @param {Rectangle} rectangle The rectangle to find the surface area of. | ||
| * @returns {Number} The approximate area of the section on the surface of this ellipsoid. |
There was a problem hiding this comment.
Suggested change
| * @returns {Number} The approximate area of the section on the surface of this ellipsoid. | |
| * @returns {Number} The approximate area of the rectangle on the surface of this ellipsoid. |
Source/Core/Ellipsoid.js
Outdated
| * Computes an approximation of the surface area of a given section of the surface of an ellipsoid using | ||
| * Gauss-Legendre 10th order quadrature. | ||
| * | ||
| * @param {Rectangle} rectangle The rectangle to find the surface area of. |
There was a problem hiding this comment.
Suggested change
| * @param {Rectangle} rectangle The rectangle to find the surface area of. | |
| * @param {Rectangle} rectangle The rectangle used for computing the surface area. |
|
Ok. That last commit should do it @lilleyse Thanks for the feedback. |
|
Just kidding I missed the CHANGES.md changes but that last commit should do it. |
ErixenCruz
force-pushed
the
ellipsoid-surfacearea
branch
from
1f6e9cd to
5255bb6
Compare
|
I know I'm not supposed to force, but I did it to fix typo in commit message. |
|
Thanks @ErixenCruz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
Ellipsoid.geodeticSurfaceNormaldividing by zero when given origin as input.Added
Ellipsoid.surfaceAreafor computing the surface area under given rectangle.